Insecure time computation #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulstrackx
force-pushed
the
raoul/rte-204-insecure_time_computation
branch
from
9d104cb to
2cc05c8
Compare
This was referenced Nov 22, 2024
Taowyoo
reviewed
Dec 5, 2024
zugzwang
reviewed
Dec 9, 2024
zugzwang
reviewed
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SGXv2 platforms support calling the rdtscp instruction inside an enclave. This PR implements logic to keep track of the time inside of an enclave. Note that the value rdtscp returns, can be manipulated by an attacker; even with these changes insecure_time is (almost) as insecure as before. There's only an option to force the time to be monotonic.
This PR is one of the parts of #648 that was split up.