-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
60 format option to match buf or rvls #314
Open
UmeSiyah
wants to merge
8
commits into
forticheprod:main
Choose a base branch
from
UmeSiyah:WIP-60-format-option-to-match-buf-or-rvls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
60 format option to match buf or rvls #314
UmeSiyah
wants to merge
8
commits into
forticheprod:main
from
UmeSiyah:WIP-60-format-option-to-match-buf-or-rvls
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UmeSiyah
force-pushed
the
WIP-60-format-option-to-match-buf-or-rvls
branch
6 times, most recently
from
November 12, 2024 07:31
55dbfec
to
562e135
Compare
Hello, I cleaned my commits and add all documentation. I remove de draft of this PR. I'll add some details of what I did in this comment to helping the review. P.S. : I'm changing my
|
UmeSiyah
changed the title
Draft:60 format option to match buf or rvls
60 format option to match buf or rvls
Nov 12, 2024
move concat clean test fix: fix rebase linter: add allow dead code alllow dead code
Add documentation of struct `FormatTemplate`
files for testing
UmeSiyah
force-pushed
the
WIP-60-format-option-to-match-buf-or-rvls
branch
from
December 1, 2024 19:01
f98d858
to
87419e2
Compare
PR update : fix the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a draft MR to have some feedback on the code until I finish to update the documentation