Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOCKS server listens on all interfaces by default #1532

Closed
ArnCo opened this issue Apr 20, 2023 · 0 comments · Fixed by #1636
Closed

SOCKS server listens on all interfaces by default #1532

ArnCo opened this issue Apr 20, 2023 · 0 comments · Fixed by #1636
Assignees

Comments

@ArnCo
Copy link

ArnCo commented Apr 20, 2023

Configuration

impacket version: v0.10.1.dev1+20230207.182628.6cd68a05
Python version: 3.9.2
Target OS: NA

By default, the SOCKS server used by ntlmrelayx.py listens on all interfaces (0.0.0.0)1080, which is dangerous.

Please see:

def __init__(self, server_address=('0.0.0.0', 1080), handler_class=SocksRequestHandler):

Any malicious agent on the same network could take advantage of the listening SOCKS proxy.
This service should only be exposed on localhost by default, and a supplemental flag should be provided in order to make it listen "publicly".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants