ntlmrelayx.py: Make SOCKS5 address and port configurable #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtpt-erikgeiser
force-pushed
the
configurable_socks_address
branch
2 times, most recently
from
655e964 to
72df5fb
Compare
rtpt-erikgeiser
force-pushed
the
configurable_socks_address
branch
from
72df5fb to
b183343
Compare
|
@gabrielg5 can you please merge this pull request? |
|
To master! 🚀 thanks for the nice addition @rtpt-erikgeiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option
-socks-addressand-socks-portwhich makes the SOCKS5 server address and port configurable. By setting the default address to127.0.0.1it also fixes #1532 which can actually be seen as a huge security issue as sensitive connections are exposed on all interfaces. Having the option to change the port is also useful for multi-user setups.The address part of
-socks-addressis also used for the SOCKS HTTP API on port 9090 (configurable with-http-api-port). Of course this also means that the web API now also uses127.0.0.1by default which is also a security improvement in my opinion.