Fix: undo untested breaking changes from #1311 that change getErrorString #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hange getErrorString for nt_status errors
gabrielg5
reviewed
Mar 18, 2024
|
Mistested #1311 and some unwanted changes were merged in master.
Eventually we may want to check if @Marshall-Hallenbeck will merge this PR after you fix the suggestion. thanks!! |
Co-authored-by: Gabriel Gonzalez <gabriel.gonzalez@fortra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1311 was untested and broke how NetExec (previously crackmapexec) handle errors. Ironically, the PR was intended to fix something for CME, but instead it broke how all nt_status errors were handled via getErrorString.
This PR reverts the changes to the getErrorString function, which is required for NetExec to be able to use Fortra's Impacket upstream. We need to use Fortra's Impacket to have NetExec packaged on Kali Linux, so please consider testing and merging this ASAP. Thank you!