Service account username when dumping LSA secrets offline #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettgus
force-pushed
the
ServiceAccountLocal
branch
4 times, most recently
from
e9188ad to
a06e072
Compare
brettgus
force-pushed
the
ServiceAccountLocal
branch
from
a06e072 to
0e3483c
Compare
anadrianmanrique
added
the
in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dumping LSA Secrets from local/offline or when utilizing -use-remoteSSMethod, the username that a service runs in the context of is not displayed and instead shows "(Unknown User)".
The code mentions this in a comment as well, that this is not currently supported.
This PR enables displaying the username with LOCAL and -use-remoteSSMethod.