Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: website deploys before merging to main #129

Closed
gnikit opened this issue Oct 12, 2023 · 3 comments · Fixed by #131
Closed

bug: website deploys before merging to main #129

gnikit opened this issue Oct 12, 2023 · 3 comments · Fixed by #131
Assignees
Labels
bug Something isn't working

Comments

@gnikit
Copy link
Member

gnikit commented Oct 12, 2023

Currently the fpm documentation webpage deploys regardless of the branch we push from!

if: ${{ github.event_name == 'push' }} #&& steps.deploy-on-push.outputs.result != 0 }}

This needs to be activated again ASAP!

@gnikit gnikit added the bug Something isn't working label Oct 12, 2023
@gnikit gnikit self-assigned this Oct 12, 2023
@gnikit gnikit mentioned this issue Oct 12, 2023
1 task
gnikit added a commit that referenced this issue Oct 12, 2023
@gnikit
Copy link
Member Author

gnikit commented Oct 12, 2023

@perazz I was wondering was there a reason why you commented that part out in fe4b128, or was it a quick way to test the deployment and forgot to change it back?

@perazz
Copy link
Contributor

perazz commented Oct 12, 2023

@gnikit, sorry for introducing that bug. I had commented that out to test the deployment of the docs on my fork and have failed to enable it back

@gnikit
Copy link
Member Author

gnikit commented Oct 12, 2023

No worries, all fixed now. On the plus side it allowed for OpenMP to reference our how-to tutorial before it got merged in main, so I would say that it all worked out well in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants