Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented count function #453

Merged
merged 8 commits into from
Jul 4, 2021
Merged

implemented count function #453

merged 8 commits into from
Jul 4, 2021

Conversation

aman-godara
Copy link
Member

Counts the number of time substring pattern has occurred in the input string.

Tasks

  • implemented count function
  • added test cases
  • documented the function
  • Elemental or Pure -> Elemental

@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Jul 4, 2021
@awvwgk awvwgk self-requested a review July 4, 2021 16:07
@milancurcic milancurcic self-requested a review July 4, 2021 16:10
milancurcic
milancurcic approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

src/stdlib_strings.f90 Outdated Show resolved Hide resolved
src/stdlib_strings.f90 Outdated Show resolved Hide resolved
awvwgk
awvwgk approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Jul 4, 2021
jvdp1
jvdp1 approved these changes Jul 4, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending a few minor comments, SGTM.
Thank you.

doc/specs/stdlib_strings.md Outdated Show resolved Hide resolved
src/stdlib_strings.f90 Outdated Show resolved Hide resolved
@aman-godara @jvdp1
Version meta-data for ford
c8fa8a5 
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
@awvwgk awvwgk merged commit c2b8338 into fortran-lang:master Jul 4, 2021
@aman-godara aman-godara deleted the count branch July 5, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancurcic milancurcic milancurcic approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aman-godara @milancurcic @jvdp1 @awvwgk