Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linspace and logspace pure functions #549

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Make linspace and logspace pure functions #549

merged 1 commit into from
Oct 5, 2021

Conversation

milancurcic
Copy link
Member

While working on #504 I noticed that linspace and logspace in stdlib_math aren't declared as pure, even though they don't have side effects. This PR makes them pure.

@milancurcic milancurcic added the topic: mathematics linear algebra, sparse matrices, special functions, FFT, random numbers, statistics, ... label Oct 5, 2021
jvdp1
jvdp1 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. Thank you

awvwgk
awvwgk approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ejovo13
Copy link
Contributor

ejovo13 commented Oct 5, 2021

👍 Nice catch!

@milancurcic
Copy link
Member Author

Thanks all.

@milancurcic milancurcic merged commit 1e81f0b into fortran-lang:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

@ivan-pi ivan-pi ivan-pi approved these changes

@awvwgk awvwgk awvwgk approved these changes

@ejovo13 ejovo13 ejovo13 approved these changes

Assignees
No one assigned
Labels
topic: mathematics linear algebra, sparse matrices, special functions, FFT, random numbers, statistics, ...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@milancurcic @ejovo13 @jvdp1 @ivan-pi @awvwgk