Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on no tests in CTest #588

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Error on no tests in CTest #588

merged 1 commit into from
Dec 8, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Dec 3, 2021

We are currently pinning CMake to version 3.16 in our CI, which doesn't allow to raise an error in case CTest doesn't find any tests. Unless there is a particular reason to test with CMake 3.16, we can use this PR to use the preinstalled CMake 3.22 version.

Closes #587

@awvwgk awvwgk added the build: cmake Issue with stdlib's CMake build files label Dec 3, 2021
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I believe @certik wrote the install_cmake.sh, but I can't remember the reason. @certik, what was the aim of this (if it is actually you who did this)?

@awvwgk
Copy link
Member Author

awvwgk commented Dec 4, 2021

I thought it was used to test the oldest supported CMake version, but the minimum required CMake version is 3.14. Maybe the original Ubuntu image 16.04 or 18.04 did not have a sufficiently new CMake version preinstalled?

@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Dec 4, 2021
@jvdp1
Copy link
Member

jvdp1 commented Dec 4, 2021

I thought it was used to test the oldest supported CMake version, but the minimum required CMake version is 3.14. Maybe the original Ubuntu image 16.04 or 18.04 did not have a sufficiently new CMake version preinstalled?

Yes, it could be that.

@jvdp1 jvdp1 requested review from certik and LKedward December 4, 2021 18:42
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the CMake version was pinned to ensure that there were no breaking changes for the minimum required version, but I can't be sure. The changes to the CI all look fine to me. What is the motivation here? i.e. what situation would cause CMake to not find any tests?

@jvdp1
Copy link
Member

jvdp1 commented Dec 6, 2021

i.e. what situation would cause CMake to not find any tests?

I have no idea why CMake didn't find the tests. I observed it for several actions, and then seemed to work fine again...

@jvdp1
Copy link
Member

jvdp1 commented Dec 8, 2021

Two approvals... I'll merge this PR. Thank you @awvwgk

@jvdp1 jvdp1 merged commit a457d88 into fortran-lang:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build: cmake Issue with stdlib's CMake build files reviewers needed This patch requires extra eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible issue: "No tests were found!!!" in CI Build (ubuntu-latest, 9, cmake)
3 participants