Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update to makefile installation instructions #594

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

gareth-nx
Copy link
Contributor

@gareth-nx gareth-nx commented Dec 12, 2021

This removes the use of the option -flto in the instructions to compile with a Makefile.

The reason for doing that is that currently, -flto can cause some tests to break - see discussion here.

Note -- this pull request initially had a failing github test. But that issue must be unrelated to this commit, because the changes here only affect README.md

This removes the use of the option `-flto` in the instructions to compile with a Makefile.

The reason for doing that is that currently, `-flto` can cause some tests to break - see [discussion here](fortran-lang#592 (comment)).
provoke tests to run again.
@awvwgk awvwgk added build: make Issue with stdlib's manual makefile build documentation Improvements or additions to documentation labels Dec 12, 2021
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me. But do we know what the problem is?
If we know it, it could be interesting to add a warning in the specs.

@gareth-nx
Copy link
Contributor Author

OK for me. But do we know what the problem is? If we know it, it could be interesting to add a warning in the specs.

Unfortunately I don't know what the problem is.

@jvdp1
Copy link
Member

jvdp1 commented Dec 16, 2021

Ok. I'll merge it. Thank you.

@jvdp1 jvdp1 merged commit 054ddf7 into fortran-lang:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build: make Issue with stdlib's manual makefile build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants