Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI option for building with fpm #757

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Conversation

jalvesz
Copy link
Contributor

@jalvesz jalvesz commented Jan 5, 2024

Related to issue #734

@awvwgk
Copy link
Member

awvwgk commented Jan 6, 2024

This approach is meant for the continuous deployment of the fpm version and not for building stdlib locally. I would prefer to not advertise this way.

@jvdp1
Copy link
Member

jvdp1 commented Jan 6, 2024 via email

@jalvesz
Copy link
Contributor Author

jalvesz commented Jan 6, 2024

I couldn't build it locally with the proposed approach, that's why I opened the issue #734.

Maybe an additional note can be included to clarify?

@jvdp1
Copy link
Member

jvdp1 commented Jan 6, 2024 via email

@jalvesz
Copy link
Contributor Author

jalvesz commented Jan 6, 2024

What about something in the lines of:
"NOTE: as fpm does not currently support fypp natively, building stdlib is done in two steps (a) launch the preprocessor through the fpm-deployment.sh script, which creates a subfolder stdlib-fpm (b) build the project using the processed files within the latter subfolder. Which can be done with the following commands:" ?

README.md Show resolved Hide resolved
@jvdp1 jvdp1 requested a review from a team January 7, 2024 14:35
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note and command lines look good to me.
Hopefully this may help new developers to start to develop stdlib with fpm.

README.md Outdated Show resolved Hide resolved
@jvdp1 jvdp1 requested review from awvwgk and a team January 7, 2024 14:40
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
@jvdp1 jvdp1 merged commit 4b993d7 into fortran-lang:master Jan 14, 2024
17 checks passed
igirault pushed a commit to igirault/stdlib that referenced this pull request Jan 17, 2024
@jalvesz jalvesz deleted the readme-info branch March 11, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants