Sharing buttons update #1121
Sharing buttons update #1121
Conversation
There was a problem hiding this comment.
Thanks for your contribution, this was something we had on our to-do list. Could you please address the style issues listed in the Travis check and update the documentation?
Could you also share the source of the Diaspora icon? We will be switching to vector icons soon and having the source could be useful.
public/js/selfoss-shares.js
Outdated
| this.register('googleplus', 'g', function(url) { | ||
| window.open('https://plus.google.com/share?url=' + encodeURIComponent(url)); | ||
| this.register('diaspora', 'd', function(url, title) { | ||
| window.open('https://share.diasporafoundation.org/?url='+encodeURIComponent(url)+'&title='+encodeURIComponent(title)+'¬es='+''); |
There was a problem hiding this comment.
+ needs to be spaced from both sides.
There was a problem hiding this comment.
Also why is '¬es='+'' needed?
There was a problem hiding this comment.
" + " Oh, really? Works in chromium... but no prob, will fix. And remove the ¬es as well.
There was a problem hiding this comment.
Btw. very nice piece of software! Never seen one where such a change requires only touching one file.
There was a problem hiding this comment.
Yeah, it is just a style preference – we are trying to have an uniform style everywhere and have a scripts to enforce that. If you have the development environment set up, you can use npm run lint:client -- --fix command to convert the code to the preferred style automatically.
There was a problem hiding this comment.
Travis was complaining about the "+" vs. " + ". That's fixed with another commit.
Graphics is from here:
https://www.deviantart.com/creativekaizen/art/Diaspora-Icon-Set-257241499
Vector is in .ai-file (Adobe Illustrator, i guess). Inkscape can open & save as .svg. Should i upload that somewhere?
There was a problem hiding this comment.
The upload here is crap. Doesn't even like a 10-Byte-.txt-file :(
There was a problem hiding this comment.
Ok, there it is:
http://www.69b.org/diaspora.svg
|
Sorry, I accidentally closed this when rebasing. Could you please push to your branch again and reopen the PR. |
|
hmmm... i don't get this github-thingie... a few minutes ago (after your rebase) it said "last commit in may 2019". In my fork... So, i re-git cloned it, applied my patches, github says you force-pushed my branch, but https://github.com/SSilence/selfoss/blob/master/public/js/selfoss-shares.js is still the old version... |
|
Think i remember the linux-folks having said they don't accept pull requests on github, because "they don't work" ... Best way forward is probably closing this PR, me deleting my fork and do it all over again tomorrow... |
|
The pull request work fine (unless I accidentally force push already merged |
|
It looks like the icon does not really fit in with the other monochrome icons:
What do you think about https://wiki.diasporafoundation.org/File:Logo.png? |
|
Ok, great! |
|
This is how it looks with the new icon:
|
|
How's this |
|
I think I still prefer the black asterisk, as that is what they have on the branding page. The other sharers (except for Facebook and Wordpress) also use positive, rather than negative images. |
|
And also, the positive is what the icon set we will most likely use provides: |
|
This |
|
I merged it now, thanks for all your work. |
G+ and delicious are no more available.