Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share button for copy #1142

Merged
merged 3 commits into from
Oct 12, 2019
Merged

Share button for copy #1142

merged 3 commits into from
Oct 12, 2019

Conversation

paradisehex
Copy link
Contributor

@paradisehex paradisehex commented Oct 2, 2019 •
edited
Loading

Fixes #1105

  • Still needs Translations.
  • It might be worth making the pop-up at the top have absolute positioning so that it can be seen when the user scrolls down and a high z-index so that mobile users can see it when they have a item open.

Otherwise should be good to go. Tested on Firefox, Chrome both on Linux desktop and android.

jtojnar
jtojnar reviewed Oct 2, 2019
View reviewed changes
public/js/selfoss-base.js Outdated Show resolved Hide resolved
public/js/selfoss-shares.js Outdated Show resolved Hide resolved
jtojnar and others added 3 commits October 12, 2019 02:50
@jtojnar
homepage: Make share options a list
4114142
@paradisehex @jtojnar
client: Add clipboard share button
adbe1cf 
Co-Authored-By: Jan Tojnar <jtojnar@gmail.com>
@jtojnar
client: make message fixed position
e7a32ba 
Otherwise it will not show when user scrolled down.
@jtojnar jtojnar force-pushed the share_button_for_copy branch from 98f278c to e7a32ba Compare October 12, 2019 01:10
@jtojnar jtojnar marked this pull request as ready for review October 12, 2019 01:11
@jtojnar
Copy link
Member

jtojnar commented Oct 12, 2019

Thanks for the help. I switched to a different clipboard library that is closer to the native version. Also changed the icon to a vector one since #1013 got finally merged.

@jtojnar jtojnar merged commit e7a32ba into fossar:master Oct 12, 2019
@jtojnar jtojnar added this to the 2.19 milestone Oct 12, 2019
@paradisehex
Copy link
Contributor Author

Haha thank you :) , I didn't end up doing much in the end.

@paradisehex paradisehex deleted the share_button_for_copy branch December 18, 2019 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.19
Development

Successfully merging this pull request may close these issues.

Review of current share button
2 participants
@paradisehex @jtojnar