Render navigation client-side #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
changed the title
jtojnar
force-pushed
the
client-side-templates-2
branch
from
9db98dd to
3d5037c
Compare
They should be propagated.
Navigation is not currently supported.
jtojnar
force-pushed
the
client-side-templates-2
branch
from
3d5037c to
3fcac45
Compare
jtojnar
added a commit
that referenced
this pull request
Jan 8, 2021
For legacy reasons, we escape tags and source titles on the server. Previously, we used server side templates where we did not escape the values but with a switch to client-side templates in #1184, we started escaping those texts in the templates. This resulted in double escaped ampersands being shown to users. Let’s unescape those values client-side for now since unescaping them in the database or on the server would break backwards compatibility for third party clients. Fixes: #1241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1064
Instead of EJS, we now use JSX syntax so we can import the templates as a JavaScript modules and do not have to mess up with ejs loader.
This is a prerequisite for filtering entries by sources and tags offline.