Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spout: Return DateTimeInterface from getDate #1341

Merged
merged 2 commits into from
Jul 9, 2022
Merged

spout: Return DateTimeInterface from getDate #1341

merged 2 commits into from
Jul 9, 2022

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Jul 9, 2022 •
edited
Loading

Reverts #1057.

@jtojnar jtojnar added the spouts label Jul 9, 2022
@jtojnar jtojnar added this to the 2.19 milestone Jul 9, 2022
jtojnar added 2 commits July 9, 2022 23:59
@jtojnar
Revert "Handle feeds with date that cannot be parsed"
5701867 
The premise of returning epoch does not seem to actually hold:

    php > var_dump(new DateTimeImmutable("ma, 08 okt 2018 10:09:29 +0000"));

    Warning: Uncaught exception 'Exception' with message 'DateTimeImmutable::__construct(): Failed to parse time string (ma, 08 okt 2018 10:09:29 +0000) at position 0 (m): The timezone could not be found in the database' in php shell code:1

This reverts commit 9e5702c.
@jtojnar
spout: Return DateTimeInterface from getDate
b66a880 
Fighting primitive obsession, one method at a time.
@jtojnar jtojnar merged commit b66a880 into master Jul 9, 2022
@jtojnar jtojnar deleted the spout-datetime branch July 9, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
spouts
Projects
None yet
Milestone
2.19
Development

Successfully merging this pull request may close these issues.
1 participant
@jtojnar