Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'homepage' config: make it possible to start with a tag or a source (#925) #927

Merged
merged 1 commit into from
May 10, 2017
Merged

'homepage' config: make it possible to start with a tag or a source (#925) #927

merged 1 commit into from
May 10, 2017

Conversation

niol
Copy link
Collaborator

@niol niol commented May 10, 2017

No description provided.

@jtojnar
Copy link
Member

jtojnar commented May 10, 2017 •
edited
Loading

Looks good.

One minor thing, if I set homepage=sources, it triggers “Invalid section: sources”. Even if it is not described in documentation, some users still might try it. Though it probably is not worth of addressing with the current routing system.

@niol
Copy link
Collaborator Author

niol commented May 10, 2017

I think the error message is enough otherwise the validation needs to be duplicated in the conf validation.

@jtojnar jtojnar merged commit 2b280b7 into fossar:master May 10, 2017
@niol niol deleted the ppr/startpath branch June 15, 2017 21:00
@niol niol restored the ppr/startpath branch June 15, 2017 21:04
@niol niol deleted the ppr/startpath branch June 15, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niol @jtojnar