Use macos 12 #145
Merged
Use macos 12 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With the macos-latest update GHA runners became Arm based. This PR switches it to use intel-based
macos-12.I also had to update some tests. Mainly, it seems like the CLI now returns zero source-units in cases where the tests expected it to return an error as a result of this release.
For now, I focused just on getting the tests green again. I can add more to the integration tests or try to cause some other error if needed.
Acceptance criteria
Broker can build on intel.
Testing plan
Integration tests pass and the CI checks here are green.
Risks
None
References
I did this as part of working on a fossa-cli arm release for Mac since releasing this for arm may be a natural next step, Though this PR does not actually do that it is a prerequisite.
Checklist