This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Traverse subdirectories in Yarn and NPM analysis #174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue arose to fix an issue for the react-rails project. Previously when we discovered NPM and yarn projects we stopped discovery after finding a project file. This results in us missing projects in subdirectories. In the following example directory structure, we would only find 1 target when we would like to find 3.
I also refactored the project filtering logic to happen before the upload step to make debugging analysis results easier.
Follow up work:
Relocate the project filtering logic to happen in between discovery and analysis.