Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Traverse subdirectories in Yarn and NPM analysis #174

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

zlav
Copy link
Member

@zlav zlav commented Dec 17, 2020

This issue arose to fix an issue for the react-rails project. Previously when we discovered NPM and yarn projects we stopped discovery after finding a project file. This results in us missing projects in subdirectories. In the following example directory structure, we would only find 1 target when we would like to find 3.

yarn.lock
build/yarn.lock
build/rails/yarn.lock

I also refactored the project filtering logic to happen before the upload step to make debugging analysis results easier.

Follow up work:
Relocate the project filtering logic to happen in between discovery and analysis.

@zlav zlav requested a review from cnr December 18, 2020 21:08
@cnr cnr merged commit f987624 into master Dec 28, 2020
@cnr cnr deleted the fix/only-skip-nodemodules branch December 28, 2020 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants