Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Fix revision read #182

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Fix revision read #182

merged 2 commits into from
Jan 27, 2021

Conversation

skilly-lily
Copy link
Contributor

We now properly read a cached .fossa.revision file.

There may still be a bug in inferDefault to not override that file, but that requires a few days to refactor and fix. This should at least fix the issue where fossa test would NEVER work when using a non-VCS and non-CLI-option revision string.

Signed-off-by: Wesley Van Melle <van.melle.wes@gmail.com>
Signed-off-by: Wesley Van Melle <van.melle.wes@gmail.com>
@skilly-lily skilly-lily requested a review from zlav January 26, 2021 19:40
Copy link
Member

@zlav zlav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, looks good to me!

@zlav zlav merged commit b20fa4e into master Jan 27, 2021
@zlav zlav deleted the fix-revision-read branch January 27, 2021 20:09
@skilly-lily
Copy link
Contributor Author

fixes fossas/issues#304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants