This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Fix parsing loop for req.txt files #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skilly-lily
suggested changes
Mar 24, 2021
| @@ -185,7 +186,7 @@ requirementParser = specification | |||
| special <- many (oneOf ['-', '_', '.']) | |||
| lod <- letterOrDigit | |||
| pure (special ++ [lod]) | |||
| identifier = label "identifier" $ (:) <$> letterOrDigit <*> (concat <$> many identifier_end) | |||
| identifier = label "identifier" $ (:) <$> (letterOrDigit <|> oneOfSpecial) <*> (concat <$> many identifier_end) | |||
There was a problem hiding this comment.
I don't think this is logically correct. Python packages (specifically, modules) do not allow most special characters. I believe the only allowed characters are [a-zA-Z0-9_].
I think the correct change is this:
Suggested change
| identifier = label "identifier" $ (:) <$> (letterOrDigit <|> oneOfSpecial) <*> (concat <$> many identifier_end) | |
| identifier = label "identifier" $ (:) <$> (letterOrDigit <|> char '_') <*> (concat <$> many identifier_end) |
There was a problem hiding this comment.
Can one of you link to a piece of documentation for this? (Ideally, add it as a comment too.)
|
Going to close this -- the issue was resolved in #235 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If a
requirements.txtfile has a line starting with a non-letter/word character, the CLI completely hangs and appears to be stuck in aParserloop.To recreate this, add a
requirements.txtfile containing the single line:_depWithUnderscore=1.2.3, and runfossa analyze --output. The CLI will hang, and never exit.I am very new to both
HaskellandParser's especially, so am not 100% confident that this "fix" doesn't open up any other issues, however I do know that this change fixes the original problem that I discovered