Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

AOSP notice files: accept paths as arguments #217

Merged
merged 7 commits into from
Mar 29, 2021

Conversation

jssblck
Copy link
Member

@jssblck jssblck commented Mar 26, 2021

Updates fossa vps aosp-notice-file to require a --ninja-files argument, which is a comma separated list of Ninja file paths to use for reconstructing the build graph.

This replaces the existing functionality of "identify and use all ninja files in the scan directory", which was not always valid.

@jssblck jssblck requested review from cnr and skilly-lily March 26, 2021 20:27
Copy link
Contributor

@skilly-lily skilly-lily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, but overall this looks good.

src/App/Fossa/VPS/Scan/RunWiggins.hs Outdated Show resolved Hide resolved
src/App/Fossa/Main.hs Outdated Show resolved Hide resolved
@jssblck jssblck merged commit fb62578 into master Mar 29, 2021
@jssblck jssblck deleted the aosp-notice-files-accept-paths branch March 29, 2021 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants