This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Conda support #226
Merged
Conda support #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skilly-lily
reviewed
Apr 15, 2021
There was a problem hiding this comment.
Left a lot of comments, mostly small stuff like simplifications.
The two critical changes are combineSuccessful and not using head.
I also have a sneaking suspicion that you have not set up the linter and formatter. We use hlint for linting and ormolu for formatting. haskell-language-server integrates with both if they're on the PATH, and configured correctly (vscode is the reference for configuration, I think).
skilly-lily
approved these changes
May 11, 2021
|
Also, please do not merge this until we have merged and deployed the conda fetcher. Doing so may cause user confusion and/or block spectrometer releases. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for conda. We will support it with 2 strategies:
conda list: this will output the dependencies to stdoutenvironment.yml: ifconda listfails, then we fall back to parsing a yml file