This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Add --depth 1000 to npm ls #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
npm lshas started to only show depth of 0 as late as npm 7.8.0. This breaks standard npm analysis, fortunately adding--depth 1000shows the full dependency graph and is backward compatible. 1000 is arbitrary but it is a round number and enforces that we will always get the full dependency graph.Acceptance criteria
npm ls --production --depth 1000is run and in environments, with newer npm versions we are able to get deep dependencies.Testing plan
Set npm to 7.8.0, run spectrometer before updating the npm command, and compare the results to what I get after updating the npm command.
Risks
I don't see any risks with this.
Checklist
CHANGELOG.md. If the PR did not mark a release, update the#Unreleased section at the top.