This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Use Diag.logWithExit_ to prevent exiting 0 on failure.
#275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlav
reviewed
Jul 2, 2021
| @@ -23,10 +19,7 @@ import Srclib.Types (parseLocator) | |||
|
|
|||
| analyzeMain :: ScanDestination -> Severity -> OverrideProject -> ImageText -> IO () | |||
| analyzeMain scanDestination logSeverity override image = withDefaultLogger logSeverity $ do | |||
| result <- runDiagnostics $ analyze scanDestination override image | |||
| case result of | |||
| Left err -> logError (renderFailureBundle err) | |||
There was a problem hiding this comment.
Is this the culprit for why this PR was necessary?
zlav
approved these changes
Jul 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
During
fossa container analyze, when syft fails, we exit with 0. This is because our raw diagnostic handler does not control exiting values. UsingDiag.logWithExit_, we can safely handle errors which terminate the program, and automatically return non-zero exit codes.This PR migrates all eligible entry points to using
Diag.logWithExit_.Acceptance criteria
Diag.logWithExit_, instead of handling manually:IO ()Testing plan
Test all modified commands in failure mode, confirm non-zero exit code.
References
Reported here http://fossa.zendesk.com/agent/tickets/2814
Closes fossas/team-analysis#626
Checklist
haskell-language-server) any haskell files I touched in this PR.docs/.Changelog.mdif this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top.