-
Notifications
You must be signed in to change notification settings - Fork 7
Run test as monorepo OR normal, not both #321
Conversation
Rather than introducing a new flag, falling back to the old behavior would be nice here. It'll be painful to remove that flag later |
I figured we wouldn't remove it, just deprecate it and make it a no-op |
@thedeerchild, @enricozb - I think we can ensure our monorepo users are on |
Disagree with the note regarding upgrade cadence, but I think there are few enough that we can manually upgrade them past it. Let's just confirm the Core version somewhere so that we can make sure to upgrade Moto this week (and tell anyone else starting with Monorepo that they need to be above that version). |
@thedeerchild Confirming: We're removing the |
Correct. Cc/ @enricozb |
Required FOSSA version is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; left a note suggesting to remove the sections added to the userguide
Overview
Previously, we tried running both normal build polling and monorepo polling at the same time. However this causes us to report incorrect errors during normal build failures. This PR attempts to detect the correct project type, and fall back to normal builds unless the user tells us to fall back to normal builds.
Requires fossas/FOSSA#6311, which has been deployed in cloud in version
3.34.19
Acceptance criteria
fossa test
andfossa report
use the same logic to detect project types.Testing plan
test
andreport
on a monorepo project, against prod.test
andreport
on a monorepo project, against a core version without the/api/cli/:locator/project
route.Risks
I'm not sure this is the right move. We are potentially introducing a failure mode where on-prem customers now have to enable a certain flag to run correctly, where they didn't before. However, I don't see a better way to handle this without obscuring errors.
References
Related to fossas/team-analysis#708
Checklist
docs/
.Changelog.md
if this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top.