This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
fix(maven): Parse platform specifiers in Maven package IDs #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a parsing issue where package IDs with platform specifiers would not parse correctly.
It also adds a unit test as well as an output fixture from the customer who reported this bug - I'm working with them to figure out whether we can actually commit the anonymized customer fixture.
Acceptance criteria
The Maven
dependency:tree
tactic should work on Maven package IDs that include platforms.Testing plan
Run
cabal test
on the unit test, and with the fixture (DM @liftM for the fixture).References
Checklist
docs/
.Changelog.md
if this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top.