Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

fix(maven): Parse platform specifiers in Maven package IDs #329

Merged
merged 4 commits into from
Aug 16, 2021

Conversation

elldritch
Copy link
Member

Overview

This PR fixes a parsing issue where package IDs with platform specifiers would not parse correctly.

It also adds a unit test as well as an output fixture from the customer who reported this bug - I'm working with them to figure out whether we can actually commit the anonymized customer fixture.

Acceptance criteria

The Maven dependency:tree tactic should work on Maven package IDs that include platforms.

Testing plan

Run cabal test on the unit test, and with the fixture (DM @liftM for the fixture).

References

Checklist

  • I added tests for this PR's change (or confirmed tests are not viable).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • I updated Changelog.md if this change is externally facing. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • I linked this PR to any referenced GitHub issues, if they exist.

@elldritch elldritch requested review from a team and skilly-lily and removed request for a team August 13, 2021 03:21
Copy link
Contributor

@skilly-lily skilly-lily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but that package format is so stupid. Optional middle components with identical separators?

@elldritch elldritch enabled auto-merge (squash) August 16, 2021 16:57
@elldritch elldritch merged commit ff9dd3c into master Aug 16, 2021
@elldritch elldritch deleted the fix/maven-platform-specifiers branch August 16, 2021 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants