This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Adds support for git sources in Podfile.lock tactic #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Supports git sources in cocoapods. Intention is to reach parity between CLIv1, and CLIv2.
It also does minor refractor.
Acceptance criteria
Testing plan
pod update
)Podfile
Risks
Although, current documentation on cocoapod resolution is not ideal, I think potential risk is not resolving when subspecs are sourced from original git source. E.g
ExampleKit
is sourced fromprivateGit
, and thenExampleKit/Logger
should also be sourced from such.Currently, this is also not supported in CLI v1. I intend to address this in subsequent PR.
References
Works on https://github.com/fossas/team-analysis/issues/721
Checklist
docs/
.Changelog.md
if this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top.