This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Fix archive compression bug #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jssblck
requested review from
a team and
spatten
and removed request for
a team
skilly-lily
approved these changes
Sep 17, 2021
| @@ -98,7 +99,7 @@ compressFile :: Path Abs Dir -> Path Abs Dir -> FilePath -> IO FilePath | |||
| compressFile outputDir directory fileToTar = do | |||
| -- Without using `fromAbsDir` for each of these directories, the conversion | |||
| -- is incorrect. `show outputDir` gives an incorrect result even though it typechecks. | |||
| let finalFile = toString outputDir </> fileToTar | |||
| let finalFile = toString outputDir </> safeSeparators fileToTar | |||
There was a problem hiding this comment.
[nit]: Can we remove the above comment while we're here? It was stale when we switched to using toString
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a bug when using
vendored-dependenciesinfossa-deps.yml, where the vendored project was in a subdirectory.Acceptance criteria
Support vendored projects in subdirectories.
Testing plan
fossa-deps.ymlfile. View it at go/cpp-vsi-demo on the branchwith-fossa-deps.Risks
None that I can think of in particular.
Checklist
Changelog.mdif this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top.