Skip to content
This repository has been archived by the owner on Apr 1, 2022. It is now read-only.

Fixes lein analysis for common CI workflows #379

Merged
merged 2 commits into from
Sep 28, 2021
Merged

Conversation

meghfossa
Copy link
Contributor

@meghfossa meghfossa commented Sep 28, 2021

Overview

This change ensures lein analysis invokes lein --version command before invoking any analysis command. This ensures

  • lein has completed it's first invocation tasks, so output of subsequent commands are not impacted.

Acceptance criteria

On clean lein install, fossa can perform analysis successfully.

Testing plan

Example project: https://github.com/meghfossa/example-projects/tree/main/clojure/with-lein
To install lein:

wget https://raw.github.com/technomancy/leiningen/stable/bin/lein
chmod +x lein
sudo cp lein /usr/local/bin/
  1. Install lein
  2. Delete lein directory: rm -rf ~/.lein (you don't need to do this if it's fresh install, and you have not invoked lein)
  3. Run fossa analyze . -o | jq (it should be successful)

Risks

N/A

References

Closes https://github.com/fossas/team-analysis/issues/743

Checklist

  • I added tests for this PR's change (or confirmed tests are not viable).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • I updated Changelog.md if this change is externally facing. If this PR did not mark a release, I added my changes into an # Unreleased section at the top.
  • I linked this PR to any referenced GitHub issues, if they exist.

@meghfossa meghfossa marked this pull request as ready for review September 28, 2021 15:27
@meghfossa meghfossa requested a review from jssblck September 28, 2021 15:27
@meghfossa
Copy link
Contributor Author

@kitified tagged you here since you have the most context on this

@meghfossa meghfossa merged commit 86bc410 into master Sep 28, 2021
@meghfossa meghfossa deleted the fix/lein-first-install branch September 28, 2021 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants