This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reports an origin for uploaded
SourceUserDefDep
s.The background here is that a customer requested a feature which we call "binary discovery". The TL;DR of this feature is that we, as a strategy in Spectrometer, identify files with binary content in the project and report them as unlicensed user-defined dependencies in Core.
This led to a follow up feature request: "please display the path at which the binary is located in the report under the
File Path(s)
column". This PR makes that happen."Origin", in this context, means the path at which the user defined dependency was identified.
This then is used to provide the actual point of the PR, which is hydrating
File Path(s)
in the report for the project when using binary discovery.Acceptance criteria
I booted a core instance that supports this information and ran a scan.
I then verified that:
File Path(s)
column with this origin.Testing plan
discovered-binary-origins
. Make sure the "File paths in reports" feature flag is enabled.--experimental-enable-binary-discovery
.Screenshots
Showing this working:
And showing that user defined deps without origins are still displayed properly:
Risks
Not particularly risky.
Checklist
Changelog.md
if this change is externally facing. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top.