This repository has been archived by the owner on Apr 1, 2022. It is now read-only.
Implement contributor tracking #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnr
reviewed
Jul 7, 2020
skilly-lily
commented
Jul 7, 2020
src/App/Fossa/Analyze.hs
Outdated
| . M.map (T.pack . iso8601Show) | ||
| . M.fromListWith max | ||
| . mapMaybe readLine | ||
| $ T.lines textContrib |
There was a problem hiding this comment.
This line got too long for me. ormolu suggested this style, so I went with it.
cnr
approved these changes
Jul 8, 2020
src/App/Fossa/Analyze.hs
Outdated
| uploadContributors baseUrl apiKey locator contributors | ||
|
|
||
|
|
||
| fetchGitContributors :: |
There was a problem hiding this comment.
[nit] can we move this to another module? (along with gitLogCmd, of course)
There was a problem hiding this comment.
Have a name/existing module in mind?
There was a problem hiding this comment.
I'd be okay with a new module named VCS.Git or similar
skilly-lily
force-pushed
the
git-contrib-count-v2
branch
from
8073b27 to
620c04e
Compare
|
@cnr would you mind rechecking? I fixed some merge conflicts and I'd like another set of eyes making sure I didn't miss something obvious. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic outline:
{"<authorEmail>": "<latest contribution date: YYYY-MM-DD>", ...}IO:git log ...outputgit log ...are ignored, since git should be taking care of that. We can add protection here later if needed.