Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled auto-filling of information other than country name during Tax Pop-up in wizard step-1 #4512

Closed
wants to merge 4 commits into from

Conversation

ShreyanshSrivastava
Copy link
Contributor

Fixes #4504

Short description of what this resolves:

The proposed changes disabled the auto-filling of information other than country name during the Tax Pop-up in wizard step-1.

Changes proposed in this pull request:

  • Added @autocomplete="some-random-string" in all the input fields separately.

old view

old-view

new view

new-view

@vercel
Copy link

vercel bot commented Jul 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/h99cq7ot0
✅ Preview: https://open-event-frontend-git-fork-shreyanshsrivastava-development.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #4512 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #4512   +/-   ##
============================================
  Coverage        22.25%   22.25%           
============================================
  Files              470      470           
  Lines             4960     4960           
  Branches             6        6           
============================================
  Hits              1104     1104           
  Misses            3855     3855           
  Partials             1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ecc320...76e27ec. Read the comment docs.

@iamareebjamal
Copy link
Member

I can still see the autocomplete

@ShreyanshSrivastava
Copy link
Contributor Author

I can still see the autocomplete

The autocomplete is now coming only for the country name field. No field other than the country name is getting filled automatically unlike previously.

@iamareebjamal
Copy link
Member

Funny, cause the issue was about the country field only, not any other, so the issue linked in the PR won't be fixed if I merge the PR 🤷‍♂️

@ShreyanshSrivastava
Copy link
Contributor Author

Funny, cause the issue was about the country field only, not any other, so the issue linked in the PR won't be fixed if I merge the PR

issue
Please guide me if doing anything wrong, from what I have understood after reading the expected line is that field should not allow auto-completion of data other than the country name, because previously clicking on that field was allowing auto-completion of all other data too including country name.

@iamareebjamal
Copy link
Member

@mariobehling Can clarify on this

@mariobehling
Copy link
Member

field should not allow auto-completion of data other than the country name

That is correct and it should choose that data from the dropdown menu as well as the form sometimes might give an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tax Information Country Field offers Autofill of other information
3 participants