Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change location search placeholder text #5242

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

Soumi150
Copy link
Contributor

@Soumi150 Soumi150 commented Oct 5, 2020

changes placeholder "search for events" to "search location"
edit

fixes #5240

@vercel
Copy link

vercel bot commented Oct 5, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/5nvlzipnb
✅ Preview: https://open-event-fronten-git-5267fd403b22bb46c7e7f140d9faa8b0d-9590ba.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #5242 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5242   +/-   ##
============================================
  Coverage        22.75%   22.75%           
============================================
  Files              490      490           
  Lines             5207     5207           
  Branches            36       36           
============================================
  Hits              1185     1185           
  Misses            4017     4017           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfecdf...5267fd4. Read the comment docs.

@maze-runnar
Copy link
Contributor

@Soumi150 it is good that you are exploring the project. Please Try to solve those issues that are labeled codeheat.

Copy link
Member

@akashgp09 akashgp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iamareebjamal
Copy link
Member

Please write the PR title properly

@Soumi150 Soumi150 changed the title issue #5240 fix change placeholder text Oct 5, 2020
@iamareebjamal iamareebjamal changed the title change placeholder text fix: change location search placeholder text Oct 17, 2020
@iamareebjamal iamareebjamal merged commit fcd732f into fossasia:development Oct 17, 2020
@auto-label auto-label bot added the fix label Oct 17, 2020
@Soumi150 Soumi150 deleted the edits branch October 18, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search field on frontpage confusing due to Wrong text
6 participants