Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug with maximum and minimum tickets per order #5252

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

Soumi150
Copy link
Contributor

@Soumi150 Soumi150 commented Oct 6, 2020

Fixes #5235

Short description of what this resolves:
When user changes minimum order to greater than maximum or vice versa ,prompt will be given.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 6, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/d1njqyd17
✅ Preview: https://open-event-fronten-git-fbd16caa91e37501db67f17a3624d7d98-066765.eventyay.vercel.app

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 1 alert when merging ca39f01 into 6f55c7f - view on LGTM.com

new alerts:

  • 1 for Overwritten property

@iamareebjamal
Copy link
Member

@maze-runnar Can you please review this and try it out

@maze-runnar
Copy link
Contributor

working fine

@iamareebjamal iamareebjamal changed the title Fix bug with maximum and minimum tickets per order fix: bug with maximum and minimum tickets per order Oct 7, 2020
@auto-label auto-label bot added the fix label Oct 7, 2020
@iamareebjamal iamareebjamal merged commit fd8d2e7 into fossasia:development Oct 7, 2020
@Soumi150 Soumi150 deleted the TicketOrder branch October 8, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when the number of minimum tickets is less than maximum. No error when maximum is less than minimum.
3 participants