Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Preserve version in docker build #5274

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

iamareebjamal
Copy link
Member

No description provided.

@auto-label auto-label bot added the chore label Oct 9, 2020
@vercel
Copy link

vercel bot commented Oct 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ixi17qfoa
✅ Preview: https://open-event-frontend-git-version-build.eventyay.vercel.app

@iamareebjamal iamareebjamal merged commit 630602c into fossasia:development Oct 9, 2020
@iamareebjamal iamareebjamal deleted the version-build branch October 9, 2020 10:54
Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 1
           

See the complete overview on Codacy

@@ -29,7 +29,8 @@ module.exports = function(environment) {

APP: {
apiHost : process.env.API_HOST || (environment === 'production' ? 'https://api.eventyay.com' : 'https://open-event-api-dev.herokuapp.com'),
apiNamespace : process.env.API_NAMESPACE || 'v1'
apiNamespace : process.env.API_NAMESPACE || 'v1',
version: process.env.npm_package_version
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found an issue: Missing space after key 'version'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants