Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stripe validation condition fix #5292

Merged
merged 2 commits into from
Oct 13, 2020
Merged

fix: stripe validation condition fix #5292

merged 2 commits into from
Oct 13, 2020

Conversation

maze-runnar
Copy link
Contributor

was showing error even if stripe box is unticked
Screenshot from 2020-10-12 22-08-04

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/byvzqcizn
✅ Preview: https://open-event-frontend-git-lost.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/models/event.js  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #5292 into development will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5292      +/-   ##
===============================================
+ Coverage        22.80%   22.85%   +0.04%     
===============================================
  Files              491      491              
  Lines             5239     5241       +2     
  Branches            37       37              
===============================================
+ Hits              1195     1198       +3     
+ Misses            4039     4038       -1     
  Partials             5        5              
Impacted Files Coverage Δ
app/models/event.js 50.00% <0.00%> (-7.15%) ⬇️
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a3c1f2...876b0be. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 45d4d7e into fossasia:development Oct 13, 2020
@maze-runnar maze-runnar deleted the lost branch October 13, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants