Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Organizer Session Page Table #5293

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #4838

Short description of what this resolves:

This PR organize the sessions page table.

Changes proposed in this pull request:

-Expand date and time column.
-Reduce the width of lock and notify column.
-Reduce the spacing between the "title" and the buttons below the title text.
-Take out AM/PM since the format is 24 hours.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screenshots

Before
Before

After
4838

@vercel
Copy link

vercel bot commented Oct 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nmime4zx6
✅ Preview: https://open-event-frontend-git-organised-sessions-page-table.eventyay.vercel.app

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal @snitin315 please review this.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #5293 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5293      +/-   ##
===============================================
+ Coverage        22.70%   22.76%   +0.05%     
===============================================
  Files              491      491              
  Lines             5241     5241              
  Branches            37       37              
===============================================
+ Hits              1190     1193       +3     
+ Misses            4046     4043       -3     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/events/view/sessions/list.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c3c86...9606ac5. Read the comment docs.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! To make use of the space even more efficiently, could you change this a bit more, please as follows.
Decrease width of:

  • Status
  • Rating
  • Lock Session

Increase width of

  • Session column

Screenshot from 2020-10-13 06-28-38

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling sir, i am working on changes you suggest. I will finish my work as soon as possible.

@@ -1,5 +1,5 @@
{{this.record}}
<div class="hidden ui divider"></div>
<div class="hidden ui divider" style="margin: 0.3em"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of hidden divider use a line break
. And see if it holds the requirement.

Copy link
Contributor Author

@sachinchauhan2889 sachinchauhan2889 Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @maze-runnar for your valuable suggestion. I will try to use break line tag instead of hidden divider.

@sachinchauhan2889
Copy link
Contributor Author

sachinchauhan2889 commented Oct 13, 2020

@mariobehling @iamareebjamal i have implemented the suggested changes, in this commit 231deed. Please review this.

Changes
In this commit I have

  • decrease the width of lock session tab.
  • decrease the width of status tab.
  • decrease the width of rating tab.
  • increase the width of title tab.

Final fix

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/controllers/events/view/sessions/list.js  1
         

See the complete overview on Codacy

@iamareebjamal iamareebjamal changed the title Organizer Session Page Table #4838 fix: Organizer Session Page Table #4838 Oct 14, 2020
@iamareebjamal iamareebjamal changed the title fix: Organizer Session Page Table #4838 fix: Organizer Session Page Table Oct 14, 2020
@auto-label auto-label bot added the fix label Oct 14, 2020
@iamareebjamal iamareebjamal merged commit 7e911dd into fossasia:development Oct 14, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the organised-sessions-page-table branch October 14, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Session Page Table: Distribute Columns more evenly and correct time info
7 participants