-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Organizer Session Page Table #5293
fix: Organizer Session Page Table #5293
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nmime4zx6 |
@mariobehling @iamareebjamal @snitin315 please review this. |
Codecov Report
@@ Coverage Diff @@
## development #5293 +/- ##
===============================================
+ Coverage 22.70% 22.76% +0.05%
===============================================
Files 491 491
Lines 5241 5241
Branches 37 37
===============================================
+ Hits 1190 1193 +3
+ Misses 4046 4043 -3
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mariobehling sir, i am working on changes you suggest. I will finish my work as soon as possible. |
@@ -1,5 +1,5 @@ | |||
{{this.record}} | |||
<div class="hidden ui divider"></div> | |||
<div class="hidden ui divider" style="margin: 0.3em"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of hidden divider use a line break
. And see if it holds the requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @maze-runnar for your valuable suggestion. I will try to use break line tag instead of hidden divider.
@mariobehling @iamareebjamal i have implemented the suggested changes, in this commit 231deed. Please review this. Changes
|
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- app/controllers/events/view/sessions/list.js 1
See the complete overview on Codacy |
Fixes #4838
Short description of what this resolves:
This PR organize the sessions page table.
Changes proposed in this pull request:
-Expand date and time column.
-Reduce the width of lock and notify column.
-Reduce the spacing between the "title" and the buttons below the title text.
-Take out AM/PM since the format is 24 hours.
Checklist
development
branch.Screenshots
Before
After