-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make CFS optional like adding org info wizard step 1 #5302
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/omthgpq46 |
Codecov Report
@@ Coverage Diff @@
## development #5302 +/- ##
===============================================
- Coverage 22.80% 22.69% -0.11%
===============================================
Files 491 491
Lines 5241 5243 +2
Branches 37 37
===============================================
- Hits 1195 1190 -5
- Misses 4041 4048 +7
Partials 5 5
Continue to review full report at Codecov.
|
Was not able to fully test due to Stripe saving issue. Updated branch to see if it works then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, in regards to the wizard it is working fine. However the CfS is still visible on the public page:
https://open-event-frontend-git-wizard-grey.eventyay.vercel.app/e/5ac8e4d9/cfs
It shows "closed" instead:
- The page should not be available if the CfS is deactivated.
@maze-runnar Please delete CfS if the organizer disables CfS |
after applying this, when I am again trying to change it - And then after saving and again opening this is working fine -
|
Does this mean the data will be deleted? This would be different to other fields where the data is still saved even if the field gets deactivated. |
Not deleting the announcement means that we'll have to add another field in DB and API and also add validation that enabling CFS actually contains CFS and disabling CFS actually has no CFS. Note that only announcement gets deleted, not other CFS fields, as we don't show CFS without announcements |
It seems deleting the CfS is the quick solution, ok. But could you add an issue to follow up here, cause it would be better if the announcement would not be deleted when it gets deactivated. Reason is: Organizers play around with features. Also they could click a field by accident. There are many reasons organizers would not want data (like the announcement) to be deleted. So, which deleting the announcement solves the current issue quickly it should not be a final fix. As a matter of fact if we delete the data we should actually have a pop up "You are deleting the announcement. Yes/No". This is all too much to go through. From the user perspective the best would be if the data does not get deleted simply. So, I suggest:
Does this work? |
I have created the issue and we'll do that in future, but the problem I was talking about, desynchronization of the field and data already exists in the system for most fields. That's why there were so many errors in the past about:
So, adding a switch which is independent of data always creates edge cases which may eventually be fixed after many iterations, but are fragile. For example, above issues are now fixed on frontend, but there is no check on the backend, so it is entirely possible via API to say the event accepts stripe for payment but not add the connection. And adding such checks in server is very difficult because the change in stripe auth and connection may happen before or after each other and thus create race problems. So, we'll add that feature in near future but it comes at development and bug cost. |
I understand. I wonder how others are doing it. An alternative would be to add a message "do you really want to do this?" every time a user switches off a feature. This was how Windows worked years ago and users hated it. So, it seems to me we need to go the way as described by you. |
Fixes #5300
Checklist
development
branch.