Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Speaker Name Shown in Overview Mode #5305

Merged
merged 2 commits into from
Oct 22, 2020
Merged

fix: Speaker Name Shown in Overview Mode #5305

merged 2 commits into from
Oct 22, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #4815

Short description of what this resolves:

In the overview mode, where the sessions are not expanded the speaker names are not shown. This PR resolves it.
Now Speaker name is shown in the overview mode of Public Session Page.

Changes proposed in this pull request:

  • Speaker name is shown in overview mode of Public Session Page.
  • His position and organisation name is also shown along with name.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Path

/e/:event_id/schedule

Screenshots

Before
Before 4815

After
after 4815

@vercel
Copy link

vercel bot commented Oct 13, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/nvv8e7b0j
✅ Preview: https://open-event-frontend-git-show-speaker-name-in-overview-mode-4815.eventyay.vercel.app

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal please review this PR.

mariobehling
mariobehling requested changes Oct 13, 2020
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unneeded space between speaker image and name. Expected: The names should move according to the number of speakers similar to the website generator.
Screenshot from 2020-10-14 00-20-18

@codecov
Copy link

codecov bot commented Oct 14, 2020 •
edited
Loading

Codecov Report

Merging #5305 into development will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5305      +/-   ##
===============================================
- Coverage        22.78%   22.72%   -0.06%     
===============================================
  Files              491      491              
  Lines             5245     5245              
  Branches            37       37              
===============================================
- Hits              1195     1192       -3     
- Misses            4045     4048       +3     
  Partials             5        5
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab5b93...eaaeb37. Read the comment docs.

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal i have implemented suggested changes. Please check.
@snitin315 please review these changes.

Changes:--

I have remove space between speaker image icon and speaker name.

Screenshots

Before

after 4815

After

After 4815

@sachinchauhan2889 sachinchauhan2889 changed the title show-speaker-name-in-overview-mode #4815 fix: Speaker Name Not Shown in Overview Mode Oct 14, 2020
@auto-label auto-label bot added the fix label Oct 14, 2020
@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal please approve these changes

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal i have removed inline CSS. please review this. please suggest any changes if required.

@Raunaksingh100
Copy link
Member

Plz squash your commits

@sachinchauhan2889 sachinchauhan2889 force-pushed the show-speaker-name-in-overview-mode-#4815 branch from bf4b344 to ed40dab Compare October 17, 2020 14:56
@sachinchauhan2889
show-speaker-name-in-overview-mode
0f308e4 
reduce-space-between-imageicon-and-name-of-speaker

arrange-code-of-sessionitem.hbs

remove-inline-CSS
@sachinchauhan2889 sachinchauhan2889 force-pushed the show-speaker-name-in-overview-mode-#4815 branch from ed40dab to 0f308e4 Compare October 17, 2020 15:10
snitin315
snitin315 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sachinchauhan2889
Copy link
Contributor Author

@mariobehling @iamareebjamal please review this PR

@mariobehling
Copy link
Member

Thank you!

@iamareebjamal iamareebjamal changed the title fix: Speaker Name Not Shown in Overview Mode fix: Speaker Name Shown in Overview Mode Oct 22, 2020
@iamareebjamal iamareebjamal merged commit 6c3d52a into fossasia:development Oct 22, 2020
@sachinchauhan2889 sachinchauhan2889 deleted the show-speaker-name-in-overview-mode-#4815 branch October 22, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@snitin315 snitin315 snitin315 approved these changes

@Raunaksingh100 Raunaksingh100 Raunaksingh100 approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public Session Page: Speaker Name Not Shown in Overview Mode
5 participants
@sachinchauhan2889 @Raunaksingh100 @mariobehling @snitin315 @iamareebjamal