Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: size of state button in sessions table in overview of events #5320

Merged
merged 11 commits into from
Oct 15, 2020

Conversation

sachinchauhan2889
Copy link
Contributor

Fixes #5318

Short description of what this resolves:

Increase size of state button.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Screnshots

before

new issue

after

fix new issue

@auto-label auto-label bot added the fix label Oct 15, 2020
@vercel
Copy link

vercel bot commented Oct 15, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/qv429nw6m
✅ Preview: https://open-event-frontend-git-status-button.eventyay.vercel.app

@snitin315
Copy link
Member

I can see some non-related past commits. Please rebase your branch correctly with fossasia:development.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #5320 into development will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5320      +/-   ##
===============================================
+ Coverage        22.70%   22.75%   +0.04%     
===============================================
  Files              491      491              
  Lines             5241     5243       +2     
  Branches            37       37              
===============================================
+ Hits              1190     1193       +3     
+ Misses            4046     4045       -1     
  Partials             5        5              
Impacted Files Coverage Δ
.../components/forms/wizard/sessions-speakers-step.js 0.00% <0.00%> (ø)
app/controllers/events/view/sessions/list.js 0.00% <ø> (ø)
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d54dd...9b35ab6. Read the comment docs.

@sachinchauhan2889
Copy link
Contributor Author

sorry for rebase problem. i am resolving this.

@iamareebjamal
Copy link
Member

That is true but as long as only required changes are in Files Changed, we can squash commits from our end. But for future reference, as @snitin315 said, please create branches from dev.

@iamareebjamal iamareebjamal merged commit 632feae into fossasia:development Oct 15, 2020
@iamareebjamal
Copy link
Member

And thanks for following up yourself on the issue

@sachinchauhan2889 sachinchauhan2889 deleted the Status-button branch October 15, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizer Session Page Table: Size of state button is less
3 participants