Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Video Stream models #5330

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 16, 2020

For #5101

For some reason, ember data is not working correctly with relationships. Need to do more research

Fixed

@vercel
Copy link

vercel bot commented Oct 16, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/lmkvruivx
✅ Preview: https://open-event-frontend-git-video-stream.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #5330 into development will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5330      +/-   ##
===============================================
- Coverage        22.69%   22.69%   -0.01%     
===============================================
  Files              491      492       +1     
  Lines             5243     5244       +1     
  Branches            37       37              
===============================================
  Hits              1190     1190              
- Misses            4048     4049       +1     
  Partials             5        5              
Impacted Files Coverage Δ
app/serializers/video-stream.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dffc33...8d2ceff. Read the comment docs.

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/unit/models/video-stream-test.ts  1
         

See the complete overview on Codacy

@mariobehling
Copy link
Member

mariobehling commented Oct 16, 2020

Oh no, too much trouble with Ember.

@iamareebjamal
Copy link
Member Author

Fixed in d560a49 (#5330) :)

Using https://emberigniter.com/saving-models-relationships-json-api/ but yes, the docs are very sparse and this information is not available anywhere in the docs

@iamareebjamal iamareebjamal changed the title wip: Video Stream chore: Add Video Stream models Nov 7, 2020
@auto-label auto-label bot added the chore label Nov 7, 2020
@iamareebjamal iamareebjamal merged commit 4fa8591 into fossasia:development Nov 7, 2020
@iamareebjamal iamareebjamal deleted the video-stream branch November 7, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants