Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use local fonts and no analytics #5333

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 17, 2020

  • Use local Google Fonts - Lato
  • Make analytics configuration conditional

Fixes #4430

@auto-label auto-label bot added the chore label Oct 17, 2020
@vercel
Copy link

vercel bot commented Oct 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/ma5uo3r89
✅ Preview: https://open-event-frontend-git-local-fonts.eventyay.vercel.app

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- config/environment.js  1
         

See the complete overview on Codacy

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #5333 into development will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5333      +/-   ##
===============================================
+ Coverage        22.68%   22.72%   +0.03%     
===============================================
  Files              491      491              
  Lines             5245     5245              
  Branches            37       37              
===============================================
+ Hits              1190     1192       +2     
+ Misses            4050     4048       -2     
  Partials             5        5              
Impacted Files Coverage Δ
app/controllers/index.js 36.36% <0.00%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcd732f...ebc7300. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove external dependencies e.g. Google fonts, maxcdn etc.
3 participants