Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show language names in original language #5353

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix: show language names in original language #5353

merged 1 commit into from
Oct 22, 2020

Conversation

pc-beast
Copy link
Member

@pc-beast pc-beast commented Oct 22, 2020

Fixes #5347

Short description of what this resolves:

It changes the the language names to the original languages respectively.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Before:
96756660-a8262a00-13d4-11eb-9c94-7035dbff0a06

After:
Screenshot from 2020-10-22 11-04-12

@vercel
Copy link

vercel bot commented Oct 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/2k70a3u4y
✅ Preview: https://open-event-frontend-git-languages.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #5353 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5353   +/-   ##
============================================
  Coverage        22.78%   22.78%           
============================================
  Files              491      491           
  Lines             5245     5245           
  Branches            37       37           
============================================
  Hits              1195     1195           
  Misses            4045     4045           
  Partials             5        5           
Impacted Files Coverage Δ
app/services/l10n.js 62.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4aabf...b7671d8. Read the comment docs.

@iamareebjamal iamareebjamal changed the title fix: changed language names to original languages fix: show language names in original language Oct 22, 2020
@iamareebjamal iamareebjamal merged commit 10fd0b4 into fossasia:development Oct 22, 2020
@pc-beast pc-beast deleted the languages branch October 22, 2020 06:51
@mariobehling
Copy link
Member

Unfortunately spelling is wrong in several languages. Also capital/non caps is not following any standard and languages are not sorted in any logical way. You could compare how this work e.g. on eventbrite, Wikipedia etc. For the sorting I also recommend we follow Wikipedia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer/Internationalization: Show languages dropdown as written in their original way
3 participants