Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Correct l10n service usage #5354

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 22, 2020

  • Only string or parametrized string must be passed in l10n service
  • Remove extra spaces from message IDs
  • Updated tanslations

@auto-label auto-label bot added the chore label Oct 22, 2020
@vercel
Copy link

vercel bot commented Oct 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/jmway21ij
✅ Preview: https://open-event-frontend-git-l10n-gen.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #5354 into development will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5354   +/-   ##
============================================
  Coverage        22.78%   22.78%           
============================================
  Files              491      491           
  Lines             5245     5245           
  Branches            37       37           
============================================
  Hits              1195     1195           
  Misses            4045     4045           
  Partials             5        5           
Impacted Files Coverage Δ
app/components/account/application-section.js 6.25% <0.00%> (ø)
app/components/events/view/export/download-zip.js 0.00% <0.00%> (ø)
app/components/forms/admin/settings/system-form.js 0.00% <ø> (ø)
app/components/forms/orders/order-form.js 0.00% <ø> (ø)
app/components/forms/session-speaker-form.js 0.00% <ø> (ø)
app/components/forms/wizard/basic-details-step.js 21.83% <0.00%> (ø)
app/components/public/ticket-list.js 20.18% <ø> (ø)
app/components/unverified-user-message.js 33.33% <0.00%> (ø)
app/controllers/account/password.js 0.00% <0.00%> (ø)
app/controllers/account/profile.js 0.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fd0b4...8f219a8. Read the comment docs.

Copy link
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- app/controllers/admin/events/list.js  2
- app/components/unverified-user-message.js  1
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants