Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wizard step 3 and 5 enhanced accordingly #5365

Merged
merged 4 commits into from
Oct 27, 2020

Conversation

terminator0309
Copy link
Contributor

@terminator0309 terminator0309 commented Oct 23, 2020

Fixes #5013

Short description of what this resolves:

Simplifies wizard Step 3 and 5 as stated in the issue.

Changes proposed in this pull request:

-Wizard step 3 : demoted "Add Custom form field" from heading to standard text.
-Wizard step 5 : "Customize registration form" renamed to -> "Customize submission forms"

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Annotation 2020-10-25 185951
Annotation 2020-10-25 190104

@vercel
Copy link

vercel bot commented Oct 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/l8y5qu7uo
✅ Preview: https://open-event-frontend-git-wizard-enhancement.eventyay.vercel.app

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #5365 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5365   +/-   ##
============================================
  Coverage        23.23%   23.23%           
============================================
  Files              489      489           
  Lines             5122     5122           
  Branches            37       37           
============================================
  Hits              1190     1190           
  Misses            3927     3927           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed361d...fbe13e3. Read the comment docs.

@mariobehling
Copy link
Member

Is this the same pull request? #5334

It is confusing to have several PRs for the same thing.

@mariobehling
Copy link
Member

It complicates things if you do not update an existing PR and instead make a new one. Also please post screenshots of the changes in your PR description to make it easier to see the changes you have done.

@terminator0309
Copy link
Contributor Author

Added screenshots...

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does the changes, but there are a lot of unrelated changes just moving code in the lines. Please revert the unnecessary indent changes.

@terminator0309
Copy link
Contributor Author

OMG ! I think i did it. That was a nightmare to fix that indentation problem. Hopefully everthing will be good this time.

@iamareebjamal iamareebjamal changed the title Wizard step 3 and 5 enhanced accordingly fix: Wizard step 3 and 5 enhanced accordingly Oct 27, 2020
@iamareebjamal iamareebjamal merged commit e019e7e into fossasia:development Oct 27, 2020
@auto-label auto-label bot added the fix label Oct 27, 2020
sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wizard Form: Simplify design
3 participants