Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set valid CFS time range #5378

Merged
merged 1 commit into from
Oct 25, 2020
Merged

fix: Set valid CFS time range #5378

merged 1 commit into from
Oct 25, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5340
As the event start date can't be before the current date, so adding cfs date before the current date will solve the issue.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@auto-label auto-label bot added the fix label Oct 25, 2020
@vercel
Copy link

vercel bot commented Oct 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/8vde4zj3n
✅ Preview: https://open-event-frontend-git-cfs-action.eventyay.now.sh

@iamareebjamal
Copy link
Member

What about the first point?

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #5378 into development will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5378      +/-   ##
===============================================
- Coverage        22.78%   22.72%   -0.06%     
===============================================
  Files              491      491              
  Lines             5245     5245              
  Branches            37       37              
===============================================
- Hits              1195     1192       -3     
- Misses            4045     4048       +3     
  Partials             5        5              
Impacted Files Coverage Δ
app/models/speakers-call.js 20.00% <0.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e4b399...224c5f2. Read the comment docs.

@maze-runnar
Copy link
Contributor Author

What about the first point?

that is not due to CFS, that is due to any other field is empty. I have tested it. CFS is not causing such errors now.

@iamareebjamal iamareebjamal changed the title fix:cfs time issue fix generating random error msg fix: Set valid CFS time range Oct 25, 2020
@iamareebjamal iamareebjamal merged commit 794b77f into fossasia:development Oct 25, 2020
@maze-runnar maze-runnar deleted the cfs-action branch October 25, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call for Speakers: Actions result in error messages at random
2 participants