Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take out search box from sponsor table #5383

Merged
merged 2 commits into from
Oct 26, 2020
Merged

fix: take out search box from sponsor table #5383

merged 2 commits into from
Oct 26, 2020

Conversation

maze-runnar
Copy link
Contributor

Fixes #5329

introducing new prop to show/hide search box.

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/9o9zv8pww
✅ Preview: https://open-event-frontend-git-sponsor-searchbox.eventyay.vercel.app

@@ -13,6 +13,7 @@
@currentPage={{this.page}}
@pageSize={{this.per_page}}
@searchQuery={{this.search}}
@notShowSearchBox={{true}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@notShowSearchBox={{true}}
@hideSearchBox={{true}}

@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #5383 into development will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5383      +/-   ##
===============================================
+ Coverage        23.23%   23.29%   +0.05%     
===============================================
  Files              489      489              
  Lines             5122     5122              
  Branches            37       37              
===============================================
+ Hits              1190     1193       +3     
+ Misses            3927     3924       -3     
  Partials             5        5              
Impacted Files Coverage Δ
app/components/tabbed-navigation.js 53.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a4255...7798ac3. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 75af986 into fossasia:development Oct 26, 2020
@maze-runnar maze-runnar deleted the sponsor-searchbox branch October 26, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sponsors Table: Search feature is not working in sponsors table in events overview page
2 participants