-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add few hindi messages translations #5394
chore: add few hindi messages translations #5394
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/rdx4506ee |
Codecov Report
@@ Coverage Diff @@
## development #5394 +/- ##
============================================
Coverage 23.29% 23.29%
============================================
Files 489 489
Lines 5122 5122
Branches 37 37
============================================
Hits 1193 1193
Misses 3924 3924
Partials 5 5 Continue to review full report at Codecov.
|
translations/hi.po
Outdated
|
||
#: app/controllers/public/index.js:121:28 | ||
msgid "Order details saved. Please fill further details within {{time}} minutes." | ||
msgstr "आदेश विवरण सहेजे गए। कृपया {{समय}} मिनटों के भीतर और विवरण भरें।" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a placeholder
msgstr "आदेश विवरण सहेजे गए। कृपया {{समय}} मिनटों के भीतर और विवरण भरें।" | |
msgstr "आदेश विवरण सहेजे गए। कृपया {{time}} मिनटों के भीतर और विवरण भरें।" |
translations/hi.po
Outdated
|
||
#: app/templates/public/index.hbs:74:10 | ||
msgid "Online Event" | ||
msgstr "ऑनलाइन कार्यक्रम" | ||
|
||
#: app/templates/public/index.hbs:87:10 | ||
msgid "Location to be announced" | ||
msgstr "" | ||
msgstr "घोषित किए जाने का स्थान" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong
translations/hi.po
Outdated
|
||
#: app/controllers/events/view/tickets/add-order.js:23:28 | ||
#: app/controllers/public/index.js:121:28 | ||
msgid "Order details saved. Please fill further details within {{time}} minutes." | ||
msgstr "" | ||
msgstr "आदेश विवरण सहेजे गए। कृपया 10 मिनट के भीतर और विवरण भरें।" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder missing and there is a duplicate translation below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
related #5217
Checklist
development
branch.