Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add few hindi messages translations #5394

Merged
merged 3 commits into from
Oct 28, 2020
Merged

chore: add few hindi messages translations #5394

merged 3 commits into from
Oct 28, 2020

Conversation

maze-runnar
Copy link
Contributor

related #5217

Checklist

  • I have read the Contribution & Best practices Guide.
  • My branch is up-to-date with the Upstream development branch.
  • The acceptance, integration, unit tests and linter pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Oct 27, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/rdx4506ee
✅ Preview: https://open-event-frontend-git-translation-hindi.eventyay.now.sh

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #5394 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5394   +/-   ##
============================================
  Coverage        23.29%   23.29%           
============================================
  Files              489      489           
  Lines             5122     5122           
  Branches            37       37           
============================================
  Hits              1193     1193           
  Misses            3924     3924           
  Partials             5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e019e7e...e56e962. Read the comment docs.

vsasvipul0605
vsasvipul0605 previously approved these changes Oct 27, 2020
translations/hi.po Outdated Show resolved Hide resolved

#: app/controllers/public/index.js:121:28
msgid "Order details saved. Please fill further details within {{time}} minutes."
msgstr "आदेश विवरण सहेजे गए। कृपया {{समय}} मिनटों के भीतर और विवरण भरें।"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a placeholder

Suggested change
msgstr "आदेश विवरण सहेजे गए। कृपया {{समय}} मिनटों के भीतर और विवरण भरें।"
msgstr "आदेश विवरण सहेजे गए। कृपया {{time}} मिनटों के भीतर और विवरण भरें।"


#: app/templates/public/index.hbs:74:10
msgid "Online Event"
msgstr "ऑनलाइन कार्यक्रम"

#: app/templates/public/index.hbs:87:10
msgid "Location to be announced"
msgstr ""
msgstr "घोषित किए जाने का स्थान"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong


#: app/controllers/events/view/tickets/add-order.js:23:28
#: app/controllers/public/index.js:121:28
msgid "Order details saved. Please fill further details within {{time}} minutes."
msgstr ""
msgstr "आदेश विवरण सहेजे गए। कृपया 10 मिनट के भीतर और विवरण भरें।"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder missing and there is a duplicate translation below

Copy link
Member

@akashgp09 akashgp09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

translations/hi.po Outdated Show resolved Hide resolved
translations/hi.po Outdated Show resolved Hide resolved
translations/hi.po Outdated Show resolved Hide resolved
translations/hi.po Outdated Show resolved Hide resolved
@iamareebjamal iamareebjamal changed the title enh: adding few hindi messages translations chore: add few hindi messages translations Oct 28, 2020
@auto-label auto-label bot added the chore label Oct 28, 2020
@iamareebjamal iamareebjamal merged commit 7686468 into fossasia:development Oct 28, 2020
sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020
Co-authored-by: Areeb Jamal <jamal.areeb@gmail.com>
@maze-runnar maze-runnar deleted the translation-hindi branch December 13, 2020 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants