Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Recursively look for route params for private CFS #5411

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

iamareebjamal
Copy link
Member

@iamareebjamal iamareebjamal commented Oct 28, 2020

Fixes #5407

@vercel
Copy link

vercel bot commented Oct 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/br4mx2nvt
✅ Preview: https://open-event-frontend-git-private-cfs.eventyay.now.sh

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #5411 into development will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5411      +/-   ##
===============================================
+ Coverage        23.30%   23.38%   +0.07%     
===============================================
  Files              491      491              
  Lines             5128     5132       +4     
  Branches            37       37              
===============================================
+ Hits              1195     1200       +5     
+ Misses            3928     3927       -1     
  Partials             5        5              
Impacted Files Coverage Δ
app/routes/public/cfs/index.js 0.00% <0.00%> (ø)
app/components/tabbed-navigation.js 33.33% <0.00%> (-20.00%) ⬇️
app/models/event.js 50.00% <0.00%> (+18.75%) ⬆️
app/components/smart-overflow.js 100.00% <0.00%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695ceee...6878318. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 07a0cc8 into fossasia:development Oct 28, 2020
sansyrox pushed a commit to sansyrox/open-event-frontend that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sessions/Speakers: Call for speakers - private link does not work
1 participant